Incorrect Windows version being reported

delphi package - automated exception handling

Incorrect Windows version being reported

Postby Somebuddy » Thu Feb 13, 2020 1:14 am

I got a bug report from a customer. The operating system reported was
"operating system : Windows 10 Tablet PC x64 build 18363"
Turns out the user is not using a tablet version and is just using regular desktop Windows 10.
Just hoping this can be fixed as I went down a long path of trying to source a tablet to test a bug that had nothing to do with a tablet in the end.
Thanks.
Somebuddy
 
Posts: 4
Joined: Thu Feb 13, 2020 1:10 am

Re: Incorrect Windows version being reported

Postby madshi » Thu Feb 13, 2020 8:40 am

I'm showing that if GetSystemMetric(SM_TABLETPC) returns true. I guess I can just as well remove it because it's not really important, and if there are "false positives" like this, it might be better to remove it. Or what do you think?
madshi
Site Admin
 
Posts: 10232
Joined: Sun Mar 21, 2004 5:25 pm

Re: Incorrect Windows version being reported

Postby Somebuddy » Thu Feb 13, 2020 7:03 pm

Yes, I think removing it is for the best.
Better to have it not included than reporting false positives.
Thanks.
Somebuddy
 
Posts: 4
Joined: Thu Feb 13, 2020 1:10 am

Re: Incorrect Windows version being reported

Postby iconic » Thu Feb 13, 2020 9:50 pm

Unfortunately that check is and can be wrong, for instance if a Desktop or true Tablet lack a physical keyboard

Issue Example:
https://codereview.chromium.org/1879953002

Regardless, Windows 10 build 18363 is identical on both the desktop and tablet devices (tablets usually just have special drivers pre-installed and loaded)
so showing if it's a tablet or not doesn't really help the user, only the OS version and build information would be useful imho. So, +1 for getting rid of the
additional information about tablets, less confusion when wrong :D

--Iconic
iconic
Site Admin
 
Posts: 960
Joined: Wed Jun 08, 2005 5:08 am

Re: Incorrect Windows version being reported

Postby madshi » Fri Feb 14, 2020 9:06 am

Ok, thanks!
madshi
Site Admin
 
Posts: 10232
Joined: Sun Mar 21, 2004 5:25 pm


Return to madExcept

Who is online

Users browsing this forum: No registered users and 8 guests