FastMM_LogStackTrace has a pointer truncation bug in x64

[davidheffernan]

In FastMM_LogStackTrace, this line:

Code: Select all

if TPAInteger(preparedStack)[i1] = 0 then begin

should be

Code: Select all

if TPAPointer(preparedStack)[i1] = nil then begin

The error is, of course, benign in x86, but means that stack traces are typically truncated to a single return value under x64.

I also discovered that FastMM_LogStackTrace is not compatible with the delayStackWalk64 conditional, again for pretty obvious reasons. I can fix that easily enough when I build the FastMM_FullDebugMode DLL but you may wish to consider making madExcept handle that situation more elegantly.

[madshi]

You're right, I'll need to look into this.