[madRes] Update Exe Resources

[Lamez]

Hi! I wrote this code but it doesn't working. Where is the problem?

Code: Select all

procedure UpdateRes(exeFile, ResName, resFile: string);
var
  resUpdateHandle : dword;
  resMem : TFileStream;
begin
  resUpdateHandle := BeginUpdateResourceW(PWideChar(wideString(exeFile)), false);
  resMem := TFileStream.Create(resFile, fmOpenRead);
  if resUpdateHandle <> 0 then
    begin
      UpdateResourceW(resUpdateHandle, WideChar(RT_RCDATA), PWideChar(PChar(ResName)), 1045,  @resmem, resmem.Size);
      EndUpdateResourceW(resUpdateHandle, false);
      resMem.Free;
    end;
end;

[madshi]

You can't use "@resMem" like that. Using "@resMem" doesn't give you the content of the file, but the content of the TFileStream object instance.

[Lamez]

Can I use resmem.Memory?

[madshi]

Not when using a TFileStream. You could use TMemoryStream instead and then use "LoadFromFile". Afterwards you can use "TMemoryStream.Memory^".

[Lamez]

It's OK?

Code: Select all

procedure UpdateRes(exeFile, ResName, resFile: string);
var
  resHandle : dword;
  resMem : TMemoryStream;
begin
  resHandle := BeginUpdateResourceW(PWideChar(wideString(exeFile)), false);
  try
    resMem := TMemoryStream.Create;
    resMem.LoadFromFile(ResFile);
  if resHandle <> 0 then
    begin
      UpdateResourceW(resHandle, PWideChar(RT_RCDATA), PWideChar(WideString(ResName)), 1045,  resmem.Memory, resmem.Size);
      EndUpdateResourceW(resHandle, False);
    end;
  finally
    resMem.Free;
  end;
end;

[madshi]

Looks alright to me.

[Lamez]

But not working...

[madshi]

That's not a very detailed error description. Could you please be a bit more specific?

[Kendy]

Code: Select all

procedure UpdateRes(exeFile, ResName, resFile: string); 
var 
  resHandle : dword; 
  resMem : TMemoryStream; 
begin 
  resHandle := BeginUpdateResourceW(PWideChar(wideString(exeFile)), false); 
  //try   <<<
    resMem := TMemoryStream.Create; 
    try   //<<<
    resMem.LoadFromFile(ResFile); 
  if resHandle <> 0 then 
    begin 
      UpdateResourceW(resHandle, PWideChar(RT_RCDATA), PWideChar(WideString(ResName)), 1045,  resmem.Memory, resmem.Size); 
      EndUpdateResourceW(resHandle, False); 
    end; 
  finally 
    resMem.Free; 
  end; 
end;

I use it OK,My OS is WinXpSp2.